Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mTLS authentication for MoP #1414

Merged
merged 23 commits into from
Sep 10, 2024
Merged

Support mTLS authentication for MoP #1414

merged 23 commits into from
Sep 10, 2024

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Aug 20, 2024 •
edited by coderzc
Loading

Motivation

SNIP-136: https://github.com/streamnative/snip/pull/79

Support mTLS authentication for MoP

Documentation

  • no-need-doc

@github-actions GitHub Actions
Copy link

@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@Technoboy- Technoboy- changed the title Add mtls test [Dont' merge] Add mtls test Aug 20, 2024
@Technoboy- Technoboy- changed the title [Dont' merge] Add mtls test [Dont' merge] Add mtls related demo Aug 23, 2024
@Technoboy- Technoboy- changed the title [Dont' merge] Add mtls related demo [Dont' merge] Add mTLS demo Aug 26, 2024
@Technoboy- Technoboy- changed the title [Dont' merge] Add mTLS demo [Dont' merge] mTLS demo Aug 26, 2024
@Technoboy- Technoboy- closed this Sep 9, 2024
@Technoboy- Technoboy- reopened this Sep 9, 2024
@coderzc coderzc changed the title [Dont' merge] mTLS demo Support mTLS authentication Sep 10, 2024
@coderzc coderzc changed the title Support mTLS authentication Support mTLS authentication for MoP Sep 10, 2024
coderzc
coderzc previously approved these changes Sep 10, 2024
View reviewed changes
gaoran10
gaoran10 previously approved these changes Sep 10, 2024
View reviewed changes
mattisonchao
mattisonchao previously approved these changes Sep 10, 2024
View reviewed changes
coderzc
coderzc reviewed Sep 10, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@coderzc coderzc dismissed stale reviews from mattisonchao, gaoran10, and themself via 9af7e82 September 10, 2024 08:29
@coderzc coderzc merged commit d2c8afc into master Sep 10, 2024
48 checks passed
Technoboy- added a commit that referenced this pull request Sep 10, 2024
@Technoboy-
Support mTLS authentication for MoP (#1414)
27a6189
coderzc
coderzc reviewed Sep 10, 2024
View reviewed changes
...java/io/streamnative/pulsar/handlers/mqtt/support/AbstractCommonProtocolMethodProcessor.java
Comment on lines +165 to +168
protected MQTTAuthenticationService.AuthenticationResult mtlsAuth(boolean fromProxy) throws MQTTAuthException {
return MQTTAuthenticationService.AuthenticationResult.FAILED;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unless code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderzc coderzc coderzc approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

@gaoran10 gaoran10 gaoran10 left review comments

Assignees

@Technoboy- Technoboy-

Labels
doc-info-missing doc-not-needed release/3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Technoboy- @gaoran10 @coderzc @mattisonchao